GtkCellRendererCombo: Use G_PARAM_EXPLICIT_NOTIFY
authorMatthias Clasen <mclasen@redhat.com>
Sun, 8 Jun 2014 15:26:04 +0000 (11:26 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 9 Jun 2014 17:30:56 +0000 (13:30 -0400)
And add explicit notification for some properties.

gtk/gtkcellrenderercombo.c

index 89ed2cf488201f134635dba88cac6465fdc96f96..78eb81bdad7c3631440c5336c068e8f0cc5356e5 100644 (file)
@@ -153,7 +153,7 @@ gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
                                                      -1,
                                                      G_MAXINT,
                                                      -1,
-                                                     GTK_PARAM_READWRITE));
+                                                     GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY));
 
   /** 
    * GtkCellRendererCombo:has-entry:
@@ -169,7 +169,7 @@ gtk_cell_renderer_combo_class_init (GtkCellRendererComboClass *klass)
                                                         P_("Has Entry"),
                                                         P_("If FALSE, don't allow to enter strings other than the chosen ones"),
                                                         TRUE,
-                                                        GTK_PARAM_READWRITE));
+                                                        GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY));
 
 
   /**
@@ -303,10 +303,18 @@ gtk_cell_renderer_combo_set_property (GObject      *object,
         break;
       }
     case PROP_TEXT_COLUMN:
-      priv->text_column = g_value_get_int (value);
+      if (priv->text_column != g_value_get_int (value))
+        {
+          priv->text_column = g_value_get_int (value);
+          g_object_notify_by_pspec (object, pspec);
+        }
       break;
     case PROP_HAS_ENTRY:
-      priv->has_entry = g_value_get_boolean (value);
+      if (priv->has_entry != g_value_get_boolean (value))
+        {
+          priv->has_entry = g_value_get_boolean (value);
+          g_object_notify_by_pspec (object, pspec);
+        }
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);